fix(release): SC-009 gate uses dumpbin on Windows (strings was blind)#35
Merged
Conversation
The release dry-run failed only on native (win-x64): the SC-009 gate
("test hooks NOT exported") lists symbols with `strings` for .dll files,
but `strings` cannot reliably read a PE export table — it missed even the
`abi_version` positive control, so the gate correctly refused a verdict
("blind, not clean") and failed. The other three RIDs (nm) pass; the code
and the binaries are fine — only the Windows inspection method was wrong.
Switch the .dll path to `dumpbin -exports` (the canonical tool for a PE
export table), made available via ilammy/msvc-dev-cmd on the Windows runner.
The positive-control + both-hooks logic is unchanged.
Latent gate (not introduced recently); surfaced by the pre-publish dry-run.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pre-publish release dry-run failed only on
native (win-x64). The SC-009 gate (verify test-hooks are NOT exported in release binaries) inspects symbols withstringsfor.dllfiles.stringscannot reliably read a Windows PE export table — it missed even theabi_versionpositive control, so the gate correctly declared itself blind ("blind, not clean") and failed with exit 1.The other three RIDs (which use
nm) pass. The code and the binaries are correct — only the Windows symbol-inspection method was wrong. This is a latent gate (not changed recently), surfaced by running the dry-run before the real publish.Fix
.dllsymbol listing now usesdumpbin -exports(the canonical tool for a PE export table) instead ofstrings.dumpbinis put on PATH viailammy/msvc-dev-cmd@v1(Windows runner only).dumpbinon Windows.weft_test_panic/weft_loro_test_panic) logic unchanged.Verification
A fresh
release.ymldry-run will be run against this branch's change onmainafter merge to confirm all four RIDs (incl. win-x64) go green.🤖 Generated with Claude Code