Repository navigation
ci: smoke tests a branch from its checkout, retry the module download - #23
Merged
Merged
Conversation
A feature branch can be merged and deleted before its smoke job fetches the commit (unknown revision), and the Go module cache sometimes fails on a just pushed commit (shallow file has changed). Branch pushes now smoke-test the checkout with a replace directive, main, tags and manual runs still fetch the pushed commit, with retries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The smoke jobs were red for reasons unrelated to the code:
go install …@<commit sha>. A quick auto-merge deleted the branch before the job fetched the commit (unknown revision).git fetch --unshallow … shallow file has changed).Changes:
scripts/smoke.sh --local <repo>: a checkout with areplacedirective, no network for the repository itself. Feature-branch pushes use it.main, tags and manual runs still fetch the pushed commit like a user would.retryaroundgo install,go getandgo mod tidy..gitignore: ignore.claude/worktrees/(agent worktrees were picked up by agit add -A; the commit was rewritten before review).Verified on this branch: smoke passes on Ubuntu, macOS and Windows in local mode. After merging, the three smoke jobs become required checks.
🤖 Generated with Claude Code