Skip to content

Gather more diagnostics when restore fails (flaky tests) - #1753

Merged
bart-vmware merged 2 commits into
mainfrom
flaky-restore-diagnostics
Oct 2, 2026
Merged

bart-vmware merged 2 commits into
mainfrom
flaky-restore-diagnostics

Conversation

@bart-vmware

Copy link
Copy Markdown
Member

Description

Tests for git.properties occasionally fail with the following error in CI builds:

[MSB4181] The "RestoreTask" task returned false but did not log an error.

This PR adds additional diagnostics, in an attempt to chase down the root cause next time it happens.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation and/or Samples, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 83.3%
Steeltoe.Common 92.9% 84.4%
Steeltoe.Common.Certificates 95.6% 84.5%
Steeltoe.Common.Hosting 83.5% 65%
Steeltoe.Common.Http 97.4% 80.9%
Steeltoe.Common.Logging 80.6% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.3% 89.4%
Steeltoe.Configuration.CloudFoundry 98.4% 92.7%
Steeltoe.Configuration.ConfigServer 91.4% 85.9%
Steeltoe.Configuration.Encryption 97.6% 87.5%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.6% 82.1%
Steeltoe.Configuration.Placeholder 94% 82.6%
Steeltoe.Configuration.RandomValue 93.2% 83.3%
Steeltoe.Configuration.SpringBoot 98.3% 85%
Steeltoe.Connectors 94.5% 85.2%
Steeltoe.Connectors.EntityFrameworkCore 81% 70.8%
Steeltoe.Discovery.Configuration 96.3% 75%
Steeltoe.Discovery.Consul 91.5% 84.5%
Steeltoe.Discovery.Eureka 90.2% 81.8%
Steeltoe.Discovery.HttpClients 89.9% 91.1%
Steeltoe.Logging.Abstractions 99.4% 95.6%
Steeltoe.Logging.DynamicConsole 100% 92.3%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.9% 87%
Steeltoe.Management.GitProperties.Build 95.2% 83.9%
Steeltoe.Management.Prometheus 96.8% 81.2%
Steeltoe.Management.Tasks 95.2% 80%
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 95.6%
Steeltoe.Security.Authentication.OpenIdConnect 87.7% 77.2%
Steeltoe.Security.Authorization.Certificate 96.8% 66.6%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware
bart-vmware force-pushed the flaky-restore-diagnostics branch from 2956087 to 48269bf Compare October 2, 2026 12:35
@bart-vmware
bart-vmware marked this pull request as ready for review October 2, 2026 13:08
@bart-vmware
bart-vmware requested a review from TimHess October 2, 2026 13:08
Comment thread src/Management/test/GitProperties.Build.Test/ProcessRunner.cs
Comment thread src/Management/test/GitProperties.Build.Test/ProcessRunner.cs
@bart-vmware
bart-vmware requested a review from TimHess October 2, 2026 14:29
@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2026

Copy link
Copy Markdown

@bart-vmware
bart-vmware merged commit 8cb3e02 into main Oct 2, 2026
25 checks passed
@bart-vmware
bart-vmware deleted the flaky-restore-diagnostics branch October 2, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants