ci: give the release upload a repository to talk to - #9
Merged
Conversation
The release job downloads the installer artifact and never checks the repository out, so gh had no git remote to infer the target from. Every gate passed, the validated installer built, and the upload died on "failed to run git: fatal: not a git repository". v2.0.1 published without its installer until it was attached by hand. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The
releasejob downloads the installer artifact and never checks the repository out.gh release uploadtherefore had no git remote to infer a target from, and died onfailed to run git: fatal: not a git repositoryafter every other gate had already passed. v2.0.1 published without its installer until it was attached by hand.The fix
One line:
GH_REPO: ${{ github.repository }}on the upload step, soghis told the repository instead of guessing at it from a working tree that does not exist.Verification
Dispatched this branch with
release_tag=v2.0.1: run 31129137378.HumWatch-Setup-v2.0.1.exeon the v2.0.1 release now showsupdatedAt 2026-08-06T22:41:55Z, replacing the hand-attached copy from 21:47. No manual step.One thing to know
That attached installer is now a rebuild from this branch (5c11a93), not from the v2.0.1 tag commit (6b37f3b). The only delta between them is this workflow's env block and a comment, so the installer payload is unaffected, but if you want the release artifact to come from the tag itself, re-dispatch with
release_tag=v2.0.1once this merges and the tag is reachable from main.🤖 Generated with Claude Code