deps: drop pytest-asyncio, nothing in the suite uses it - #11
Merged
Conversation
There is no asyncio_mode setting, no @pytest.mark.asyncio, no async def test_, and no import of pytest_asyncio anywhere in the tree. Every async path in tests/test_request_limits.py and tests/test_peer_discovery_security.py runs through asyncio.run() inside an ordinary sync test. The pin was left behind by the API auth and TLS work and has been carrying a pytest ceiling ever since, which is what turned the CVE-2025-71176 bump into a coupled two-package change. 239 passed, 5 skipped with the package genuinely absent from the venv, unchanged from the run with it installed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8.
What
Removes
pytest-asynciofromrequirements-dev.txt. One line.Why
Nothing uses it. There is no
asyncio_modesetting (nopyproject.toml,pytest.ini,setup.cfg, ortox.iniin the repo at all), no@pytest.mark.asyncio, noasync def test_, and no import ofpytest_asyncioanywhere in the tree. Every async path intests/test_request_limits.pyandtests/test_peer_discovery_security.pygoes throughasyncio.run()inside an ordinary sync test.It came in with the API auth and TLS work and has been carrying a
pytest<9ceiling ever since. That ceiling is what turned CVE-2025-71176 into a coupled two-package bump instead of a one-line one. Dropping it removes both the dependency and the next version of that problem.Verification
Fresh venv with the package genuinely absent (
importlib.util.find_spec('pytest_asyncio') is Noneasserted before the run), not just deleted from the requirements file. Identical counts to the run with it installed.🤖 Generated with Claude Code