Repository navigation
Clarify web conversion flow and refresh comparison previews - #26
Merged
Merged
Conversation
Stanback
marked this pull request as ready for review
October 19, 2026 21:08
Stanback
enabled auto-merge (squash)
October 19, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web converter previously opened on an unexplained sample time and presented inputs/results as separate tall cards. This layout study starts with a blank time and an explicit “Try an example” action, groups the desktop comparison, and keeps editable inputs before results on phones.
The three course results have clearer selected/original states, with restrained hover borders that preserve the selected fill. The numerical panel stays static. Calculation factors and the source explanation sit in a keyboard-accessible disclosure, closed initially, with a route to full methodology. Phone rows have tighter vertical spacing and deliberate save/copy/download action rows; the reviewed 390×844 comparison fits all actions above navigation, while shorter and larger-text views scroll normally. A compact next-standard shortcut uses the existing youth table and the unadjusted entered swim; altitude/other systems route to the full benchmark view. NCAA stays the default and Colorado remains a quiet optional setting. Shared URLs and saved/recent comparisons still restore their explicit swims. Reset clears the web time; remembered swimmer settings retain their existing contract. Loading the demonstration alone does not add conversion history.
The README now leads with an actual-build converter crop showing inputs, all three courses and the next standard. The detailed review contains matching light/dark, phone arrival/input/result, Colorado and narrow long-time captures, with source hashes. Existing paired native home captures were reviewed and retained: native layout and default sample behavior are unchanged in this web PR. No widget/MCP presentation or calculation engine changed.
Positioning now leads with a private offline swim companion: compare courses, understand published benchmarks and keep a small local scratchpad. README/product notes distinguish web saved comparisons from native development builds’ actual practice/meet records. General logger expansion, cloud sync, coach dashboards and hosted aggregation remain outside the roadmap. Native colors/icons are shared; this web layout has not automatically propagated to SwiftUI/Compose.
Validation:
The owner approved the web design on October 19, 2026. All hosted checks passed on the reviewed implementation, including the polish pass. The branch is now synchronized with main for final merge checks. Paired native input-first/blank behavior, new benchmark datasets and experimental prediction graphics are separate work, not shipped by this PR.
Actual-build review · Desktop comparison · Benchmark shortlist