Repository navigation
Internal: window code compiled once for both layouts - #86
Open
StackEnjoyer wants to merge 1 commit into
Open
StackEnjoyer wants to merge 1 commit into
StackEnjoyer wants to merge 1 commit into
Conversation
…nce for both layouts The layout hooks dispatch on gui.layout: each hook has a barrier that passes the layout on, a fallback on AbstractLiveLayout and the methods of the layouts (`_pin!(gui, layout::AppLayout, obj)`); code of one layout that is no hook takes the view and reads `_app(gui)` or `_compact(gui)`. The aliases AppView and CompactView are gone; the tests ask `gui.layout isa AppLayout`. AGENTS.md states the rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal changes
gui.layout, never on the view typeCloses #79