Repository navigation
ed25519: add Wycheproof verification tests - #84
Open
DicksonWu654 wants to merge 1 commit into
Open
DicksonWu654 wants to merge 1 commit into
DicksonWu654 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Wycheproof Ed25519 vectors (C2SP/wycheproof at
65ca494) topackages/ed25519as Vitest cases. All 210 run: 117 valid, 64 invalid, and the 29acceptableones only need to return a boolean. Nothing is skipped and they all pass.Each case goes straight through
verify()with the raw public key, message and signature.verify()throws on wrong-length keys and signatures, so the test treats those two specific errors as a reject and rethrows anything else.The JSON is checked in under
packages/ed25519/test-vectors/with Wycheproof's Apache-2.0 LICENSE and a README noting the source commit.Testing:
npm run buildandnpm testpass and it adds about 5s across the source and compiled runs