Dead code removal#48
Merged
Merged
Conversation
benjaminaubin
approved these changes
Jul 25, 2023
benjaminaubin
left a comment
benjaminaubin
left a comment
Contributor
There was a problem hiding this comment.
Looks fair enough!
benjaminaubin
suggested changes
Jul 25, 2023
benjaminaubin
approved these changes
Jul 25, 2023
jenuk
pushed a commit
that referenced
this pull request
Jul 26, 2023
LinearFalcon
pushed a commit
to LinearFalcon/generative-models
that referenced
this pull request
Jul 6, 2024
* Remove old commented-out attention code * Mark two functions as likely unused * Use exists() and default() from sgm.util
LinearFalcon
pushed a commit
to LinearFalcon/generative-models
that referenced
this pull request
Jul 6, 2024
This reverts commit b5b5680.
SevanBrodjian
pushed a commit
to SevanBrodjian/sd-latent-exploration
that referenced
this pull request
Aug 12, 2024
* Remove old commented-out attention code * Mark two functions as likely unused * Use exists() and default() from sgm.util
SevanBrodjian
pushed a commit
to SevanBrodjian/sd-latent-exploration
that referenced
this pull request
Aug 12, 2024
This reverts commit b5b5680.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on figuring out the runtime deps (as discussed in #17), I found some dead/duplicate code; this cleans it up (or marks it for possible future removal). 🧹