Fix custom game paths being lost after restart - #125
Open
Lyapsus wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom Spore or Galactic Adventures path set in the settings only lasts until the next restart.
GameManager.initialize()setsisSporeAuto/isGAAutototruewhen the path read fromconfig.propertiesvalidates, so the nextsaveSettings()writesAUTOback. On Windows the registry detection hides this; on Linux (Steam under Proton) the game is gone after every second launch.The second commit makes a custom path that no longer validates fall back to the auto-detected game instead of leaving no game for that session.
Tested on Linux with the Steam version of Spore and GA: with the paths in
config.properties, 2.2.27 writesAUTOfor both on the next save, this branch keeps them, and an invalid path is still written back asAUTO.