Skip to content

deps: ignore the heapless batch RUSTSEC-2026-0574..0582 (none reachable), revisit by 2026-12-31 - #110

Open
SovereignTechnology wants to merge 2 commits into
mainfrom
deps/rustsec-2026-0582-heapless
Open

SovereignTechnology wants to merge 2 commits into
mainfrom
deps/rustsec-2026-0582-heapless

Conversation

@SovereignTechnology

@SovereignTechnology SovereignTechnology commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

cargo deny fails every nfx check since nine heapless advisories were published together on 2026-11-18. Main is affected too; #108, which changes only JavaScript, showed it.

The advisories. RUSTSEC-2026-0574 to -0582 are all unsound, not vulnerabilities, and every one is fixed only in heapless >= 0.9.4. The affected functions:

  • IndexMap::insert and ::truncate (-0582, -0576);
  • Deque::try_from and ::make_contiguous (-0579, -0581);
  • SortedLinkedList FindMutView::pop and ::zeroize (-0574, -0578);
  • spsc::Spsc::peek (-0575);
  • the pools' treiber stack (-0580);
  • panic-safety in Deque/HistoryBuf/IndexMap clears and in vec::IntoIter::drop (-0577).

Why none is reachable here. heapless enters only through two crates, and no nfx crate names a heapless type:

  • heapless 0.7.17 comes through iroh's postcard 1.1.3, which uses only heapless::Vec and heapless::String.
  • heapless 0.8.0 comes through nostr 0.45 > faster-hex 0.10.1, which uses only heapless::String and heapless::Vec (src/encode.rs:13).

Both were read from the .crate files whose sha256 equals the lock's checksum (postcard 6764c3b5…, faster-hex 04839bdf…). -0577's Vec case needs an element whose Drop panics. The elements here are bytes, or serde-visited values of crates that never name heapless.

Why not upgrade. No release of postcard or faster-hex uses heapless >= 0.9.4: faster-hex 0.10.1 and 1.0.0 both require ^0.8, and nostr 0.45.x requires faster-hex ^0.10.

Change. Dated ignores in crates/deny.toml and crates/desktop/deny.toml, in the same shape as RUSTSEC-2026-0387 and -0543: reasons, paths, a removal condition, and revisit by 2026-12-31. Nothing else changes. deny.toml is not under crates/ci/locked.sha256.

Summary by CodeRabbit

  • Chores
    • Updated security advisory review records for nine advisories affecting a dependency. The records document the review rationale and set December 31, 2026, as the date to revisit the advisories.

…r-hex), revisit by 2026-12-31

heapless 0.8.0 IndexMap::insert is unsound on a full map (u16::MAX). It
enters only via nostr 0.45 > faster-hex 0.10.1, which uses heapless only
for String and Vec, never IndexMap. No faster-hex release moves to
heapless >= 0.9.4 (0.10.1 and 1.0.0 require ^0.8). Same dated-ignore
shape as RUSTSEC-2026-0387 and -0543, in both deny.toml files.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Both crate-level cargo-deny policies add exceptions for nine heapless advisories, RUSTSEC-2026-0574 through RUSTSEC-2026-0582. The entries describe dependency paths, affected APIs, usage assessments, and revisit conditions.

Changes: Heapless advisory policy

Layer / File(s) Summary
Add heapless advisory exceptions
crates/deny.toml, crates/desktop/deny.toml
Both policies add ignore entries for nine heapless advisories. The comments describe the dependency paths through postcard and faster-hex, state that those dependencies use only Vec and String, and specify a revisit date of 2026-12-31 and removal conditions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: dependencies

Merge Risk: Minimal · up to 59002

This change adds documented, dated advisory exceptions to the dependency audit policies so that CI can pass while the heapless upgrade is blocked. It has no runtime behavior impact. It is low risk to merge, and the revisit date of 2026-12-31 keeps the exceptions temporary.

Architecture risk: Low · up to 59002

The change affects 1 system.

Changed systems: crates

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — crates (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in crates/deny.toml: Adds comments describing the nine heapless advisories, the dependency paths through postcard and faster-hex, and the stated usage and reachability assessments; the comments specify removal when both dependencies move to heapless 0.9.4 or later and a revisit date of 2026-12-31.
  • observed — Modified behavior in crates/deny.toml: Adds cargo-deny ignore entries for RUSTSEC-2026-0574 through RUSTSEC-2026-0582, each with a reason identifying the advisory’s affected heapless API and stating the documented usage assessment and revisit date.
  • observed — Modified behavior in crates/desktop/deny.toml: Adds exceptions for nine heapless unsoundness advisories, each with a reason identifying the affected API and usage context. The comments state heapless enters through postcard and faster-hex, which use only Vec and String, and specify revisiting by 2026-12-31 and removal when both dependencies move to a fixed heapless version.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: adding dated cargo-deny ignores for the heapless advisory batch RUSTSEC-2026-0574 through 0582, with the stated reason that none are reachable and a 2026-12-31 revisit…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the main change: adding dated cargo-deny ignores for the heapless advisory batch RUSTSEC-2026-0574 through 0582, with the stated reason that none are reachable and a 2026-12-31 revisit date. The raw summary and PR objectives both describe ignore entries in crates/deny.toml and crates/desktop/deny.toml for these advisories, so the title matches the changeset. The title is long (95 characters), but it is specific and not vague.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f7ea01f-dac3-424e-89a7-fe35c744512b
Commits

Reviewing files that changed from the base of the PR and between 2dd0109 and 5900248.

Files selected for processing: 2

  • crates/deny.toml
  • crates/desktop/deny.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@sovtechpro sovtechpro Bot added the size/S Lines changed by this pull request: S (sovtechpro[bot]) label Nov 19, 2026
…le), revisit by 2026-12-31

Nine heapless advisories published together, every one fixed only in
heapless >= 0.9.4. heapless enters only via postcard 1.1.3 (0.7.17) and
nostr > faster-hex 0.10.1 (0.8.0); both use only heapless Vec and
String, and no nfx crate names a heapless type. The affected functions
are IndexMap, Deque, SortedLinkedList, spsc, the pools, and Vec IntoIter
drop with a panicking element Drop: none reachable. Replaces the single
-0582 entry.
@SovereignTechnology SovereignTechnology changed the title deps: ignore RUSTSEC-2026-0582 (heapless 0.8.0, unreachable via faster-hex), revisit by 2026-12-31 deps: ignore the heapless batch RUSTSEC-2026-0574..0582 (none reachable), revisit by 2026-12-31 Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Lines changed by this pull request: S (sovtechpro[bot])

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant