SC-54182 Remove promoted illustrations

[marciopmoreira6]

Summary

• Deprecate and stop rendering illustrations in PromotedSection and SelectionCards
• Remove illustration-related styling and stories
• Add regression tests confirming deprecated illustrations are ignored

Testing

• Not run (not requested)

[netlify]

✅ Deploy Preview for echoes-react ready!

Name	Link
🔨 Latest commit	da971a6
🔍 Latest deploy log	https://app.netlify.com/projects/echoes-react/deploys/6a75a83a410a9a0009540f1b
😎 Deploy Preview	https://deploy-preview-746--echoes-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hashicorp-vault-sonar-prod]

SC-54182

[gitar-bot]

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Removes illustrations from promoted sections and selection cards while adding regression tests for the change. Consider updating PromotedSection and SelectionCards to avoid using deprecated forwardRef.

💡 Quality: PromotedSection/SelectionCards still use deprecated forwardRef

📄 src/components/promoted-section/PromotedSection.tsx:95 📄 src/components/selection-cards/SelectionCards.tsx:83

Both components remain wrapped in forwardRef. Per the project convention for React 19, ref should be accepted as a regular prop instead. Since this PR already touches the PromotedSection signature to add rest-prop forwarding, it is a reasonable candidate to migrate to ref-as-prop; not a blocker, but worth flagging for a follow-up.

✅ 1 resolved

✅ Quality: Prefer destructuring out illustration over mutating restProps

📄 src/components/promoted-section/PromotedSection.tsx:106-111
In PromotedSection the deprecated illustration prop is excluded from the forwarded restProps via delete restProps.illustration (needed so React does not emit an illustration attribute on the DOM node). Mutating the rest object works but is less idiomatic and easy to overlook; destructuring it out is clearer and self-documenting, e.g. { ..., illustration: _illustration, ...restProps } (or // eslint-disable-next-line @typescript-eslint/no-unused-vars). This keeps the exclusion co-located with the other prop declarations.

🤖 Prompt for agents

Code Review: Removes illustrations from promoted sections and selection cards while adding regression tests for the change. Consider updating PromotedSection and SelectionCards to avoid using deprecated forwardRef.

1. 💡 Quality: PromotedSection/SelectionCards still use deprecated forwardRef
   Files: src/components/promoted-section/PromotedSection.tsx:95, src/components/selection-cards/SelectionCards.tsx:83

   Both components remain wrapped in `forwardRef`. Per the project convention for React 19, `ref` should be accepted as a regular prop instead. Since this PR already touches the PromotedSection signature to add rest-prop forwarding, it is a reasonable candidate to migrate to `ref`-as-prop; not a blocker, but worth flagging for a follow-up.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube