Skip to content

ECHOES-397 Add issue location marker layer 3 tokens - #743

Open
2amelia wants to merge 2 commits into
mainfrom
add-issue-location-marker-layer-3-tokens
Open

ECHOES-397 Add issue location marker layer 3 tokens#743
2amelia wants to merge 2 commits into
mainfrom
add-issue-location-marker-layer-3-tokens

Conversation

@2amelia

@2amelia 2amelia commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add new semantic design tokens for issue location marker states in light and dark themes
  • regenerate the public themed token outputs with the new token names
  • extend the design token cssVar test to cover the new contract

Validation

  • yarn build-tokens --brand=Brand-A
  • yarn jest src/utils/tests/design-tokens-test.ts
  • yarn ts-check
  • yarn build
  • yarn test-ci
  • DESIGN_TOKEN_BRAND=Brand-A yarn validate-ci

Review notes

  • introduces new layer-3 semantic tokens, so designer/developer review of the token contract is recommended

@netlify

netlify Bot commented Aug 2, 2026

Copy link
Copy Markdown

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 7c8696e
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a6f894aa3a4180008bb8d27
😎 Deploy Preview https://deploy-preview-743--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Aug 2, 2026

Copy link
Copy Markdown

ECHOES-397

Comment on lines +59 to +73
"issue-location-marker": {
"colors": {
"background": {
"default": {
"$extensions": {
"studio.tokens": {
"modify": {
"type": "alpha",
"value": "0.35",
"space": "lch"
}
}
},
"$type": "color",
"$value": "{echoes.color.palette.red.400}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Quality: New issue-location-marker design tokens need designer+dev review

This PR introduces new layer-3 semantic design tokens (issue-location-marker.colors.background.{default,hover,selected} and foreground.{default,selected}) in both light.json and dark.json. Per the design-token review policy, new tokens should be reviewed by both a designer and a developer as a checkpoint (not a blocker) to confirm the token contract, naming, and palette/alpha choices are intentional. The generated outputs (dark uses alpha-modified red.400 for background default/hover and red.200 for selected/foreground; light uses solid red palette values) appear consistent, so this is just the recommended sign-off.

Was this helpful? React with 👍 / 👎

@gitar-bot

gitar-bot Bot commented Aug 2, 2026

Copy link
Copy Markdown
Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Adds new layer-3 semantic design tokens for issue location markers across light and dark themes. Consider designer and developer review of the new token contract to ensure intended usage.

💡 Quality: New issue-location-marker design tokens need designer+dev review

📄 design-tokens/tokens/component/dark.json:59-73 📄 design-tokens/tokens/component/light.json:59-73

This PR introduces new layer-3 semantic design tokens (issue-location-marker.colors.background.{default,hover,selected} and foreground.{default,selected}) in both light.json and dark.json. Per the design-token review policy, new tokens should be reviewed by both a designer and a developer as a checkpoint (not a blocker) to confirm the token contract, naming, and palette/alpha choices are intentional. The generated outputs (dark uses alpha-modified red.400 for background default/hover and red.200 for selected/foreground; light uses solid red palette values) appear consistent, so this is just the recommended sign-off.

🤖 Prompt for agents
Code Review: Adds new layer-3 semantic design tokens for issue location markers across light and dark themes. Consider designer and developer review of the new token contract to ensure intended usage.

1. 💡 Quality: New issue-location-marker design tokens need designer+dev review
   Files: design-tokens/tokens/component/dark.json:59-73, design-tokens/tokens/component/light.json:59-73

   This PR introduces new layer-3 semantic design tokens (`issue-location-marker.colors.background.{default,hover,selected}` and `foreground.{default,selected}`) in both light.json and dark.json. Per the design-token review policy, new tokens should be reviewed by both a designer and a developer as a checkpoint (not a blocker) to confirm the token contract, naming, and palette/alpha choices are intentional. The generated outputs (dark uses alpha-modified red.400 for background default/hover and red.200 for selected/foreground; light uses solid red palette values) appear consistent, so this is just the recommended sign-off.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

sonarqube-next Bot commented Aug 2, 2026

Copy link
Copy Markdown

@2amelia
2amelia requested a review from marciopmoreira6 August 2, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant