ECHOES-397 Add issue location marker layer 3 tokens - #743
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "issue-location-marker": { | ||
| "colors": { | ||
| "background": { | ||
| "default": { | ||
| "$extensions": { | ||
| "studio.tokens": { | ||
| "modify": { | ||
| "type": "alpha", | ||
| "value": "0.35", | ||
| "space": "lch" | ||
| } | ||
| } | ||
| }, | ||
| "$type": "color", | ||
| "$value": "{echoes.color.palette.red.400}" |
There was a problem hiding this comment.
💡 Quality: New issue-location-marker design tokens need designer+dev review
This PR introduces new layer-3 semantic design tokens (issue-location-marker.colors.background.{default,hover,selected} and foreground.{default,selected}) in both light.json and dark.json. Per the design-token review policy, new tokens should be reviewed by both a designer and a developer as a checkpoint (not a blocker) to confirm the token contract, naming, and palette/alpha choices are intentional. The generated outputs (dark uses alpha-modified red.400 for background default/hover and red.200 for selected/foreground; light uses solid red palette values) appear consistent, so this is just the recommended sign-off.
Was this helpful? React with 👍 / 👎
Code Review 👍 Approved with suggestions 0 resolved / 1 findingsAdds new layer-3 semantic design tokens for issue location markers across light and dark themes. Consider designer and developer review of the new token contract to ensure intended usage. 💡 Quality: New issue-location-marker design tokens need designer+dev review📄 design-tokens/tokens/component/dark.json:59-73 📄 design-tokens/tokens/component/light.json:59-73 This PR introduces new layer-3 semantic design tokens ( 🤖 Prompt for agentsOptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|





Summary
Validation
Review notes