move header out of source pane - #217
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Source Pane to remove the in-pane header UI and associated header-focused metadata, while introducing new UI infrastructure (dialogs root) and beginning a “view mode” model for the editor.
Changes:
- Removes the Source Pane header components and trims metadata types down to editor-focused fields (
contentType,eTag). - Refactors
SourceProvider/SourceEditorCardstate to use aviewMode('source' | 'rdfxml') instead ofdirty/editingflags. - Adds dialog infrastructure (
solid-ui-dialogs-root) and introduces a new delete dialog component.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Simplifies metadata typing and replaces dirty/editing with viewMode in SourcePaneState. |
| src/sourcePane.ts | Renders the Source Pane without the header and adds a dialogs root element. |
| src/sourcePane.css | Adds box-sizing: border-box to the pane container. |
| src/resourceLoader.ts | Narrows response metadata extraction to editor needs (contentType, eTag). |
| src/primitives/context.ts | Simplifies SourceContext to match reduced metadata/state surface. |
| src/components/ui/resource-actions-menu/DeleteResourceDialog.ts | Adds a new Solid UI dialog component for delete confirmation. |
| src/components/source-provider/SourceProvider.ts | Removes header rendering and updates context wiring to new state/metadata types. |
| src/components/source-editor-card/SourceEditorCard.ts | Adds view-mode-dependent content handling and shifts dirty/editing tracking logic. |
| src/components/header/* | Removes Source Pane header implementation and styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SharonStrats
force-pushed
the
file-explorer-header
branch
from
August 5, 2026 07:50
bd42bf2 to
af6ae3c
Compare
…istry@3.1.2-2 solid-ui@3.1.3-15) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the header into solid-panes so it can be used by all panes. Some additional code improvements where needed.