Repository navigation
package dokeili - #364
Open
SharonStrats wants to merge 1 commit into
Open
package dokeili#364SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
SharonStrats
requested review from
bourgeoa
and
a balanced review from Copilot
November 19, 2026 11:50
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The pinned solidos-toolkit override implementation is unavailable locally, and source tests cannot establish generated-artifact CJS/ESM loading or browser compatibility of remaining transitive imports.
No open issues 🎉
What changed in this PR
This PR adjusts solid-logic’s build to bundle Dokieli’s ACL package and selected dependencies, avoiding direct CommonJS loading of Dokieli’s ESM-only entry.
Changes:
- Adds a bundling allowlist for Dokieli, RDF/JS packages, and N3 while keeping other bare package imports external.
- Documents the intended ESM and CommonJS bundling behavior.
| File | Description |
|---|---|
vite.config.mts |
Customizes dependency externalization to bundle the selected ACL dependencies. |
README.md |
Explains the bundling behavior and its CommonJS compatibility purpose. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.