Support for the Input feature on the Manage access dialog - #336
Open
SharonStrats wants to merge 2 commits into
Open
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Input normalization, nondeterministic merging, WebID detection, origin validation, and failure caching can produce incorrect or stale access subjects.
Review effort: Balanced
Findings: 1
Open (5)
Unvalidated vCard URLs can be mistaken for WebIDs · New Origin validation accepts non-HTTP schemes and query strings · New Failed catalog responses are cached permanently · New Concurrent merges choose nondeterministic labels and sources · New Empty source selection incorrectly falls back to all defaults · New
What changed in this PR
Adds directory-based subject discovery and ACL subject classification for Manage Access input.
Changes:
- Searches contacts, groups, FOAF friends, and the Solid catalog.
- Classifies entered ACL subjects.
- Exposes directory APIs through
SolidLogicand package exports.
| File | Description |
|---|---|
test/directoryLogic.test.ts |
Tests individual directory sources. |
src/types.ts |
Defines directory and ACL APIs. |
src/logic/solidLogic.ts |
Initializes directory logic. |
src/index.ts |
Exports new public APIs. |
src/directory/friendsDirectory.ts |
Discovers FOAF connections. |
src/directory/directoryLogic.ts |
Coordinates directory searches. |
src/directory/directoryHelpers.ts |
Provides matching, merging, and labeling helpers. |
src/directory/contactsDirectory.ts |
Discovers contacts and groups. |
src/directory/catalogDirectory.ts |
Loads catalog entries. |
src/acl/aclLogic.ts |
Exposes subject classification. |
src/acl/accessControlSubjects.ts |
Classifies ACL subject kinds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


On the input we needed a search for people and groups so I took what I had done previously and fixed it up a bit, improved the code. Also I decided to make a directory service here so that we can use the service everywhere.
It is configurable, you can pass in what you want to search for one or a combination of friends, contacts, groups, and the catalog from solid.
There are some caveats like your address book/s need to be in your type indexes in order to search for contacts and groups in them.
Here is the original PR SolidOS/solid-ui#725. I think I will close it if we go this way.