Feature/contacts pane redesign - #301
Draft
m5x5 wants to merge 13 commits into
Draft
Conversation
Member
|
So far so good. |
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
…right place Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
timea-solid
reviewed
Jul 31, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
While any is a good start, we should improve it to be more specific at some point.
Good work!
| type Visibility = 'public' | 'private' | null | ||
|
|
||
| /** Globe and lock marks for the visibility badge, sized to its text. */ | ||
| const globeIcon = html` |
Member
There was a problem hiding this comment.
don't we have this icons on lucide?
|
|
||
| /** The empty state's circled address-book icon; the wording next to it is | ||
| * plain HTML in renderEmpty. */ | ||
| const emptyIllustration = html` |
Member
There was a problem hiding this comment.
Pls try and use lucide icons directly as we have in solid-ui or profile-pnae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#295