Repository navigation
v2.1.0 Npm publish - #222
Merged
Merged
Conversation
…y@5.0.1 solid-logic@6.0.0 solid-ui@5.0.1)
…y@5.0.1 solid-logic@6.0.0 solid-ui@5.0.1)
…test run
solid-logic 6.2.0 added @dokieli/web-access-control, which is ESM-only: "type":
"module" and an "exports" map declaring only types and import, with no require
condition. solid-logic's build externalises every bare import, so its CJS output
does require("@dokieli/web-access-control"), which jest's CJS resolver cannot
load (ERR_PACKAGE_PATH_NOT_EXPORTED). Every suite that touches solid-logic failed
to run, so `npm run prepublishOnly` never reached the build.
Map the package to its ESM entry and let babel transform it. @rdfjs and n3 join
transformIgnorePatterns because they are in that module's import graph.
Temporary: delete both lines when activitystreams-pane moves to vitest, which
resolves ESM natively. The defect itself is in solid-logic's CJS build, not here.
…y@5.1.1 solid-logic@6.2.0 solid-ui@5.1.0)
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The solid-logic upgrade introduces an ESM-only transitive dependency whose export restriction is bypassed only in Jest, leaving browser bundles and published-library consumer imports unverified without runtime validation.
No open issues 🎉
What changed in this PR
Prepares activitystreams-pane v2.1.0 for npm publication by updating its Solid dependencies and adapting Jest to the new dependency graph.
Changes:
- Bumps the package version and upgrades
pane-registry,solid-logic, andsolid-uito newer versions with caret ranges. - Refreshes the lockfile, adding access-control dependencies and removing the transitive Vite/Vitest toolchain.
- Updates Jest transformation and module mapping to handle the ESM-only access-control package.
| File | Description |
|---|---|
package.json |
Updates the release version and Solid dependency ranges. |
package-lock.json |
Synchronizes release metadata and resolved dependencies. |
jest.config.mjs |
Adds transformation exceptions and an access-control entry-point mapping. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.