Repository navigation
Sync/main from staging - #217
Merged
Merged
Conversation
…yarn-05b1f1d78b Bump qs from 6.14.2 to 6.15.2 in the npm_and_yarn group across 1 directory
Ci staging
Fix authn tests
…@3.1.3-3 pane-registry@3.1.2-0) (latest: rdflib@2.3.9)
auto update solidosDependencies
…vitystreams-pane into solidosDependencies
Solidos dependencies
…logic@4.0.8-0 solid-ui@3.1.3-3) (latest: rdflib@2.3.9)
…logic@4.0.8-0 solid-ui@3.1.3-4) (latest: rdflib@2.3.9)
…logic@4.0.8-1 solid-ui@3.1.3-9) (latest: rdflib@2.4.0)
update solidos dev dependencies
…logic@6.0.0-0 solid-ui@5.0.0-0) (latest: rdflib@2.4.0)
solid-ui/solid-logic modular builds load @uvdsl/solid-oidc-client-browser, whose ESM build uses import.meta.url. Jest transforms it (it is in transformIgnorePatterns) but the babel config left import.meta untouched, breaking the CJS executor. Add babel-plugin-transform-import-meta to rewrite it; a no-op for app/webpack builds since src/ has no import.meta.
…logic@6.0.0-0 solid-ui@5.0.0-0) (latest: rdflib@2.4.0)
Staging version
…y@5.0.1 solid-logic@6.0.0 solid-ui@5.0.1)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Mutable privileged workflows, an overly broad test shim, and an unused runtime dependency should be addressed.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Synchronizes staging into main for the 2.0 release, updating SolidOS dependencies, test compatibility, and automation.
Changes:
- Upgrades SolidOS dependencies and package version.
- Adapts Jest/Babel for updated ESM dependencies.
- Adds dependency automation and publishing permissions.
| File | Description |
|---|---|
.github/dependabot.yml |
Enables weekly dependency updates. |
.github/workflows/ci.yml |
Adds dependency synchronization and publishing permissions. |
babel.config.mjs |
Transforms import.meta. |
jest.config.mjs |
Transpiles selected ESM dependencies. |
package.json |
Updates version and dependencies. |
package-lock.json |
Locks the updated dependency tree. |
test/jest.setup.ts |
Handles duplicate custom-element registration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+19
to
+20
| uses: SolidOS/solidos/.github/workflows/update-solidos-deps.yml@main | ||
| secrets: inherit |
Comment on lines
+72
to
75
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| uses: SolidOS/solidos/.github/workflows/publish-prerelease.yml@main |
Comment on lines
+18
to
+20
| window.customElements.define = ((name: string, constructor: CustomElementConstructor, options?: ElementDefinitionOptions) => { | ||
| if (window.customElements.get(name)) { | ||
| return; |
| "dependencies": { | ||
| "pane-registry": "^4.0.0", | ||
| "pane-registry": "^5.0.1", | ||
| "patch-package": "^8.0.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.