Repository navigation
docs(manifest): name .NET in help text, messages and comments - #1682
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 3 commits intoNov 3, 2026
Merged
Conversation
Oskar Haarklou Veileborg (BarrensZeppelin)
approved these changes
Oct 31, 2026
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/dotnet-socket-facts-text
branch
from
October 31, 2026 20:55
37628d6 to
7a9963a
Compare
| commandName: 'dynamic-sbom-inference', | ||
| description: | ||
| 'Recursively discover gradle/sbt/maven build roots and generate a Socket facts SBOM for each', | ||
| 'Recursively discover gradle/sbt/maven/dotnet build roots and generate a Socket facts SBOM for each', |
Contributor
There was a problem hiding this comment.
Nit: spelling out the build tools makes this label easier to scan.
Suggested change
| 'Recursively discover gradle/sbt/maven/dotnet build roots and generate a Socket facts SBOM for each', | |
| 'Recursively discover .NET, Gradle, Maven, and sbt build roots and generate a Socket facts SBOM for each', |
| type: 'boolean', | ||
| description: | ||
| 'Generates dynamic SBOMs via the Gradle/sbt/Maven package manager tools for more accurate results than static resolution. Scans every build root under CWD first, so the configurator only asks about ecosystems actually found; --exclude-paths matches are bulk-disabled, others configured individually.', | ||
| 'Generates dynamic SBOMs via the Gradle/sbt/Maven/.NET package manager tools for more accurate results than static resolution. Scans every build root under CWD first, so the configurator only asks about ecosystems actually found; --exclude-paths matches are bulk-disabled, others configured individually.', |
Contributor
There was a problem hiding this comment.
Nit: the slash-separated list and semicolon make this help text hard to scan.
Suggested change
| 'Generates dynamic SBOMs via the Gradle/sbt/Maven/.NET package manager tools for more accurate results than static resolution. Scans every build root under CWD first, so the configurator only asks about ecosystems actually found; --exclude-paths matches are bulk-disabled, others configured individually.', | |
| 'Uses .NET, Gradle, Maven, and sbt tools to generate dynamic SBOMs with more accurate results than static resolution. It scans build roots under CWD, asks only about detected ecosystems, then disables roots matched by --exclude-paths and configures the rest individually.', |
Comment on lines
+44
to
+45
| Currently supported language: bazel [beta], dotnet [beta], gradle [beta], | ||
| kotlin (through gradle) [beta], maven [beta], scala [beta]. |
Contributor
There was a problem hiding this comment.
Nit: this list contains build tools and ecosystems, not only languages.
Suggested change
| Currently supported language: bazel [beta], dotnet [beta], gradle [beta], | |
| kotlin (through gradle) [beta], maven [beta], scala [beta]. | |
| Currently supported ecosystems: bazel [beta], dotnet [beta], gradle [beta], | |
| kotlin (through gradle) [beta], maven [beta], scala [beta]. |
Comment on lines
+91
to
+92
| // failed in the same projects (or, outside any project, also outside one): the | ||
| // lenient resolver reports both forms for one failure. |
Contributor
There was a problem hiding this comment.
Nit: the parenthetical is hard to parse.
Suggested change
| // failed in the same projects (or, outside any project, also outside one): the | |
| // lenient resolver reports both forms for one failure. | |
| // failed for the same projects, or when both failures have no project. The | |
| // lenient resolver reports both forms for a single failure. |
Contributor
Author
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/dotnet-socket-facts-text
branch
from
November 2, 2026 11:58
7a9963a to
9cbc291
Compare
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/dotnet-socket-facts-text
branch
2 times, most recently
from
November 2, 2026 15:11
3a50bf3 to
4b720a4
Compare
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/dotnet-socket-facts-text
branch
2 times, most recently
from
November 3, 2026 11:29
f0a5e78 to
ce3cb76
Compare
Help text and messages for dynamic SBOM inference, the setup wizards, `socket manifest` and `scan create`/`scan reach` now list .NET next to Gradle, sbt and Maven, and comments on the shared facts pipeline describe it in build-tool-neutral terms.
List the build tools in full in the dynamic-SBOM-inference and setup help, call the supported list ecosystems, and clarify the no-project dedup rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jeppe Fredsgaard Blaabjerg (jfblaa)
force-pushed
the
jfblaa/dotnet-socket-facts-text
branch
from
November 3, 2026 11:29
ce3cb76 to
339065a
Compare
Jeppe Fredsgaard Blaabjerg (jfblaa)
deleted the
jfblaa/dotnet-socket-facts-text
branch
November 3, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
What
User-facing wording and comment edits that go with .NET support (#1678), split out so the code and test PRs below stay focused.
--helptext and messages for dynamic SBOM inference,socket manifest setup,socket manifestandscan create/scan reachlist .NET next to Gradle, sbt and Maven, with the matching help snapshots and message assertions.No behaviour change.
🤖 Generated with Claude Code
Note
Low Risk
Documentation and help-text only; no logic or API behavior changes.
Overview
Updates user-facing strings and internal comments so .NET appears alongside Gradle, sbt, and Maven everywhere the CLI already treats those ecosystems together—without changing runtime behavior.
CLI help and errors:
--helpoutput and shared flag text (--exclude-paths,--dynamic-sbom-inference,--auto-manifest) now mention .NET projects and dynamic SBOM inference for .NET. The top-levelsocket manifesthelp lists dotnet [beta]. “No build root found” messages for dynamic SBOM inference, recursive setup, and scan flows now read “Gradle, sbt, Maven or .NET” instead of JVM-only wording. Matching inline snapshots and unit test assertions were updated.Developer comments: Docs on the facts pipeline (rollup copy step,
build-tool.mts, record protocol inrecords.mts,run.mtsentryFile, reachability sidecar comment) were broadened from JVM-only to build-tool-neutral or explicitly include dotnet where relevant.Reviewed by Cursor Bugbot for commit 37628d6. Configure here.