fix(fix): skip unreadable dirs in manifest discovery (EACCES scandir)

[Martin Torp (mtorp)]

Problem

socket fix (and socket scan create / socket scan reach) crash with

✖  Unexpected error:  EACCES: permission denied, scandir '.../data/postgres/pgdata'

when the project contains a directory the running user cannot enter — e.g. a postgres pgdata data directory owned by another uid (mode drwx------), or an unreadable Docker volume mount.

#1339 added --exclude-paths (and socket.yml projectIgnorePaths already existed) specifically to skip such directories, but neither worked — the command crashed identically even with the path excluded.

Root cause

globWithGitIgnore (src/utils/glob.mts) runs two fast-glob walks:

1. a .gitignore discovery walk (fastGlob.globStream(['**/.gitignore'], …)) to build the ignore set, then
2. the main package-file walk.

--exclude-paths (additionalIgnores) and projectIgnorePaths were only ever applied to walk 2. Walk 1 runs first with just the default ignore list, so it scandirs straight into the unreadable directory and throws before any user exclusion can take effect. That's why excluding the path didn't help.

Verified empirically with a reproduction (chmod 000 dir): the discovery walk throws EACCES; the main walk with the exclude succeeds (the #1339 fix is correct, just unreachable); both walks with suppressErrors succeed.

Fix

In globWithGitIgnore:

1. Thread projectIgnorePaths + --exclude-paths into the .gitignore discovery walk (negations dropped — for a discovery walk they could only re-include a subtree) so explicit exclusions govern the entire discovery, as the flag documents.
2. suppressErrors: true on both walks — a directory the user cannot read cannot contain manifests they could scan anyway, so skip it instead of aborting the whole run. This makes the tool robust without requiring any flag.

Test

New regression test in src/utils/glob.test.mts reproduces the scenario with a real chmod 000 directory (skipped under root, where perm checks are bypassed, and on Windows). It fails with the exact EACCES … scandir before the fix and passes after.

Release

Cuts 1.1.112 (package.json + CHANGELOG.md).

---

Note

Medium Risk
Changes shared file-walking used by fix and scan; suppressErrors could mask rare filesystem errors, but scope is limited to skipping unreadable paths users could not scan anyway.

Overview
v1.1.112 fixes manifest discovery so socket fix and socket scan create no longer die on EACCES: permission denied, scandir when the repo contains directories the current user cannot read (e.g. Postgres pgdata, Docker volume mounts).

globWithGitIgnore runs a separate walk to find **/.gitignore before the main file walk. --exclude-paths and socket.yml projectIgnorePaths were only applied to the main walk, so the discovery walk could still enter an unreadable tree and abort before exclusions took effect. The PR applies the same ignore patterns to the discovery walk (dropping negated ! patterns there) and sets suppressErrors: true on both walks so unreadable directories are skipped instead of failing the whole command.

A POSIX integration test uses a real chmod 000 directory (skipped on Windows and as root).

^{Reviewed by Cursor Bugbot for commit 21c7770. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.}

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 21c7770. Configure here.}