tests: update missing-index tests for missing_index='error' default - #59
Merged
Merged
Conversation
04c2064 made read_ATL11_granule_cloud_items() raise FileNotFoundError for a missing geoIndex by default (missing_index='error'), with the old warn-and-skip behaviour available as missing_index='skip'. Two tests still expected the old default and failed. Pass missing_index='skip' in those, and add tests that the default raises, for both local and remote index paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tests/test_remote_cache.py (added in 2d438e1) imports fsspec at module level, but fsspec is only in the optional 'cloud' extra, not in the pixi dev environment CI runs in. Collection failed with ModuleNotFoundError and pytest stopped before running any tests (exit code 2). Add fsspec to [tool.pixi.feature.dev.dependencies] and re-lock with pixi 0.79.0, the version CI pins. The lock change only adds fsspec 2026.9.0. Checked with `pixi install --locked -e dev` and `pixi run coverage`: 268 passed, 4 skipped, test_remote_cache.py included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
04c2064 made read_ATL11_granule_cloud_items() raise FileNotFoundError for a missing geoIndex by default (missing_index='error'), with the old warn-and-skip behaviour available as missing_index='skip'. Two tests still expected the old default and failed. Pass missing_index='skip' in those, and add tests that the default raises, for both local and remote index paths.