mosaic: don't share the default spacing list between mosaics - #58
Merged
Merged
Conversation
mosaic.__init__ used a mutable default (spacing=[None,None]), and update_spacing() modified that list in place through the spacing property. The first mosaic built in a process therefore set the spacing for every later mosaic created without an explicit spacing, so a coarse-resolution mosaic built after a fine one was gridded at the fine spacing (mostly empty/NaN). Default to None and copy the spacing argument into a new list. Also fix update_spacing() computing dy from x instead of y. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mosaic.init used a mutable default (spacing=[None,None]), and update_spacing() modified that list in place through the spacing property. The first mosaic built in a process therefore set the spacing for every later mosaic created without an explicit spacing, so a coarse-resolution mosaic built after a fine one was gridded at the fine spacing (mostly empty/NaN). Default to None and copy the spacing argument into a new list.
Also fix update_spacing() computing dy from x instead of y.