Fix cross-ring copies and procedure lifetime cleanup - #1381
Open
cxzhong wants to merge 2 commits into
Open
Conversation
cxzhong
marked this pull request as ready for review
August 6, 2026 05:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROC_CMDattribute cleanup and protect procedure metadata for the full call lifetime.mp_Copy, plus compiler-warning cleanups in touched code.Testing
OM_TRACKbuilds completed successfully.-Wall -Wextra -Werror; the standalone library parser passed the same gate.unused-parameterandunused-value).make -j2 checkpassed.proc_lifetime.tst: release 1/1 andOM_TRACK1/1 passed; generated baseline decoded and passedgzip -t.New.lst: 88/94 passed. The remaining six are environment-dependent failures caused by unavailable optional NTL/FLINT, gfanlib, or externalrrefsupport:bug_absprimdec,enumpoints,gfanlib,oscar3905,rref, andtestParametrization_2.Review
Three independent review passes covered
mp_Copy, procedure lifetime/reference handling, and the complete release diff. No remaining P1/P2 findings were identified. Repeated list/attribute lifetime tests showed no memory growth.