Repository navigation
Conversation
ValerianRey
approved these changes
Nov 3, 2026
ValerianRey
left a comment
ValerianRey
left a comment
Member
There was a problem hiding this comment.
good job ty! you can merge
| }; | ||
|
|
||
| pub fn square<T: Tensor + ?Sized>(u: Rc<T>) -> LeftComposition<T> { | ||
| pub fn square<V: Mul<Output = V> + Copy + 'static, U: Tensor<V> + ?Sized>( |
Member
There was a problem hiding this comment.
i think it would be better to stick to a naming convention, like A and B are for value types (like you did in tensor.rs) and U and V are tensor types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
T, which defaults tof32, so existing code works unchangedLeftCompositioncan change the value type, e.g. a comparison turnsf32intoboolf32,f64andi64where_takes aboolconditionsquare,negate,scale,clampand the functions that only move indices are genericpowis removedzeros,onesandeyehave no input to infer the type from