ci: fail the pull request whose changeset would generate an unformatted changelog - #54
Merged
Merged
Conversation
bendersej
force-pushed
the
fix-web-changelog-format
branch
from
September 28, 2026 09:23
ba5f666 to
6910522
Compare
…enerate an unformatted changelog fails its own pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The version PR #53 failed Web / Formatting: the 1.9.0 changeset has a blank line between its lead paragraph and its list, which
changeset versionturns into a blank line inside a list item that Prettier rejects. The failure only showed in the version PR, after the feature PR had merged. The version PR should only ever contain generated output, never a formatting fix.Changes
versionscript is a purechangeset version(no formatter), for every package.package.json: it runs the release'snpm run version, then the formatting checks the version PR runs, so a changeset whose generated CHANGELOG is not formatted fails the pull request that adds it.Notes
versionscript: the original 1.9.0 changeset fails the check (as chore: version packages #53 did) and the fixed one passes.