Skip to content

docs(collectors): harness plist examples use the installed copy - #1700

Merged
jaywedgeworth22 merged 1 commit into
mainfrom
claude/UM-1594-plist-install-path
Oct 18, 2026
Merged

jaywedgeworth22 merged 1 commit into
mainfrom
claude/UM-1594-plist-install-path

Conversation

@jaywedgeworth22

@jaywedgeworth22 jaywedgeworth22 commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Refs UM-1594

Summary

Updates the macOS collector installation documentation and LaunchAgent template examples so they reference the installed collector copy at apps/usage-monitor-collectors/scripts/ rather than the previous runtime path (apps/usage-monitor-collector-runtime/current/scripts/). The guidance for installing collectors now points to scripts/install-collectors.sh.

Changes

  • LaunchAgent plist examples (deepseek, opencode, fx):

    • Program arguments now point to the installed collector copy under apps/usage-monitor-collectors/scripts/.
    • Setup instructions now direct users to run scripts/install-collectors.sh (referencing the install runbook) instead of the runtime update script.
  • Runbook (docs/runbooks/mac-collectors-install.md):

    • Adds a "Harness feeds: DSH, opencode, fx (UM-1594)" section documenting the three LaunchAgents that feed harnesses without a vendor billing API.
    • Includes a table mapping each label to its data source and producer.
    • Documents shared runtime requirements (Node 24 path, USAGE_INGEST_TOKEN), DSH's USAGE_MONITOR_EXCLUDE_BOTFLEET_CHILDREN=1 setting, and the initial 180-day backfill with watermark state stored in ~/.cache/usage-monitor/collector-state/.

Review notes

  • A medium-severity finding flags that the provided task description is insufficient for business logic validation.
  • A low-severity finding notes a minor formatting issue in the new runbook section: two ASCII spaces after a period before "Create" on line 69.

…(Refs UM-1594)

The plist examples referenced the old runtime-symlink updater, whose symlinked path defeats every collector's main guard.  They now use ~/apps/usage-monitor-collectors from install-collectors.sh, and the runbook gains the DSH, opencode and fx LaunchAgent table.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Oct 18, 2026

Copy link
Copy Markdown

UM-1594

@jaywedgeworth22
jaywedgeworth22 enabled auto-merge (squash) October 18, 2026 01:33
@jaywedgeworth22
jaywedgeworth22 merged commit c2d4712 into main Oct 18, 2026
11 checks passed
@jaywedgeworth22
jaywedgeworth22 deleted the claude/UM-1594-plist-install-path branch October 18, 2026 01:37
@kody-ai

kody-ai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

⚠️ 2 Kody Rule(s) were not evaluated

These rules declare that they need repository context beyond this diff, and the review could not retrieve it, so they were not judged on this pull request:

  • Never move or delete existing app support.html URLs
  • Prefer Sentry for new observability; do not add new Datadog RUM/APM surfaces
Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

@kody-ai

kody-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown

kody code-review Kody Rules low

Double space after the period in 'API. Create' violates the single-space sentence-gap formatting rule. Collapse to one space to produce 'API. Create'.

Kody rule violation: Sentence gap by surface: two ASCII spaces in files, U+00A0 plus a space in rendered copy and GitHub text

@kody-ai

kody-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown

kody code-review Business Logic medium

🤔 Insufficient Task Context

I found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details.

🔍 What I need to validate:

  • Business requirements and acceptance criteria
  • Expected behavior and business rules
  • Edge cases and constraints to consider

💡 How to improve the task context:

  • Add a description to the linked ticket
  • Include acceptance criteria or business rules
  • Describe the expected behavior after the change

⚠️ Important:

A task title alone is not sufficient to determine whether the implementation is correct or complete.


💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant