fix(packaging): declare openssl as an AUR dependency - #184
Merged
Conversation
The exclusion rested on straces of help-only command paths; visa scan and api start --tls load libssl, and without openssl visa scan dies on "No usable version of libssl was found".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#179 shipped
depends=('glibc' 'libgcc' 'libstdc++' 'icu')and an explicit comment saying OpenSSL was not required. That was wrong, and the way it was wrong is worth recording: the strace behind it covered--version,doctor, and three--helpinvocations — paths that never touch cryptography. Re-running the trace over paths that do the actual work says otherwise.ivicli --versionivicli api start(plain)ivicli server start …ivicli visa scanivicli api start --tls-self-signedvisa scanis not an edge case, so this would have hit an Arch user on a system that happened to lack openssl.Proven by removal rather than by reading the trace, the same way
icuwas:zlibis deliberately not declared. It is loaded on the same paths, but by libssl rather than by the CLI — removing zlib makes libssl itself unloadable — and Arch'sopensslalready depends on it. namcap confirms the judgement from the other side: declaring it earnsDependency included, but may not be needed ('zlib').namcap now reports five expected warnings instead of three: it flags
opensslexactly as it flagsicu, because it reads the ELF and both arrive throughdlopen.packaging/aur/README.mdlists all five with the two removal commands that check the claim, so the next maintainer verifies rather than trusts the tool that is blind here.Verified end to end after the change:
makepkgbuilds,.PKGINFOcarries the five depends, and onarchlinux:basewith no dotnet on PATH the installed package runs--versionand completesvisa scan..SRCINFOregenerated from the edited PKGBUILD.