ensure config file is closed in PopulateConfig - #763
Open
mateeaaa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an unclosed file descriptor resource leak in
ApiServer.PopulateConfigby ensuring that configuration files opened viaos.Openare properly closed after decoding.Root Cause Analysis
In
api.go, thePopulateConfigmethod opens a JSON configuration file to populate proxies during server startup or reload.While
PopulateJsonconsumes the passedio.Readerviajson.NewDecoder(data).Decode(...), it does not take ownership of closing the underlying stream. As a result, the*os.Filehandle allocated byos.Open(filename)remains open indefinitely for the lifetime of the process.Solution
Add
defer file.Close()immediately following the successfulos.Openerror check. This guarantees that the file descriptor is released back to the OS regardless of whether JSON decoding succeeds or fails.Changes Made
api.goinPopulateConfig: addeddefer file.Close()right after the initial error check.