add grep tool result formatter#953
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
This was referenced Jun 16, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2026
juniper-shopify
requested changes
Jun 17, 2026
juniper-shopify
left a comment
Contributor
There was a problem hiding this comment.
The overall structure is great — mirroring the GLOB formatter's partition + NOTE + ok_line pattern keeps the stack consistent and readable. The doc comment is thorough with clear examples.
One change needed: the match-detection heuristic is too loose and will misclassify some status messages as grep matches. Details in the inline comment.
2cdf530 to
c1c5f21
Compare
8703607 to
e9eaf19
Compare
c1c5f21 to
8b0e6ba
Compare
e9eaf19 to
14ab748
Compare
8b0e6ba to
80213e4
Compare
14ab748 to
ebed756
Compare
80213e4 to
344a60e
Compare
ebed756 to
2379c3a
Compare
2379c3a to
dd2b19c
Compare
344a60e to
4cdad17
Compare
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #971