Skip to content

add grep tool result formatter#953

Open
LasmarKhalifa wants to merge 1 commit into
06-15/tool-result-format-globfrom
06-15/tool-result-format-grep
Open

add grep tool result formatter#953
LasmarKhalifa wants to merge 1 commit into
06-15/tool-result-format-globfrom
06-15/tool-result-format-grep

Conversation

@LasmarKhalifa

@LasmarKhalifa LasmarKhalifa commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Closes #971

@juniper-shopify juniper-shopify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall structure is great — mirroring the GLOB formatter's partition + NOTE + ok_line pattern keeps the stack consistent and readable. The doc comment is thorough with clear examples.

One change needed: the match-detection heuristic is too loose and will misclassify some status messages as grep matches. Details in the inline comment.

Comment thread lib/roast/cogs/agent/providers/claude/tool_result.rb Outdated
Comment thread test/roast/cogs/agent/providers/claude/tool_result_test.rb
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-glob branch from 2cdf530 to c1c5f21 Compare June 19, 2026 18:42
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-grep branch 2 times, most recently from 8703607 to e9eaf19 Compare June 19, 2026 20:41
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-glob branch from c1c5f21 to 8b0e6ba Compare June 19, 2026 20:41
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-grep branch from e9eaf19 to 14ab748 Compare June 22, 2026 22:21
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-glob branch from 8b0e6ba to 80213e4 Compare June 22, 2026 22:21
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-grep branch from 14ab748 to ebed756 Compare June 22, 2026 23:50
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-glob branch from 80213e4 to 344a60e Compare June 22, 2026 23:50
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-grep branch from ebed756 to 2379c3a Compare June 23, 2026 16:43
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-grep branch from 2379c3a to dd2b19c Compare June 23, 2026 18:33
@LasmarKhalifa LasmarKhalifa force-pushed the 06-15/tool-result-format-glob branch from 344a60e to 4cdad17 Compare June 23, 2026 18:33
@LasmarKhalifa LasmarKhalifa marked this pull request as ready for review June 23, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants