Use force for upgrade confirmations#3835
Open
gonzaloriestra wants to merge 1 commit into
Open
Conversation
This was referenced Jul 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
from
76fb93b to
369faff
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
b06380d to
8406940
Compare
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Contributor
Author
|
/snapit |
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
8406940 to
2250851
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
from
369faff to
0672b0f
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
2250851 to
0147582
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
2 times, most recently
from
08e73e9 to
d09a3d5
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
0147582 to
97b8c94
Compare
gonzaloriestra
changed the title
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
97b8c94 to
29ebc6c
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
from
d09a3d5 to
4cda90f
Compare
lucyxiang
approved these changes
Jul 3, 2026
lucyxiang
left a comment
lucyxiang
left a comment
Contributor
There was a problem hiding this comment.
Review assisted by pair-review
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
29ebc6c to
ceded69
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
from
4cda90f to
253bc92
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
ceded69 to
bec4169
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
from
253bc92 to
4af21bf
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
bec4169 to
a44fa79
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
2 times, most recently
from
139b2e1 to
fe2e4fa
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
a44fa79 to
d156023
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-link-create-flags
branch
from
d156023 to
8612b1e
Compare
gonzaloriestra
force-pushed
the
gdt-hydrogen-upgrade-yes
branch
from
fe2e4fa to
4d03e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/22879
shopify hydrogen upgradeprompted for upgrade confirmation and could prompt again before overwriting generated upgrade instructions.WHAT is this pull request doing?
Uses existing
--forceonhydrogen upgradeto skip the upgrade confirmation prompt and overwrite an existing generated instructions file for the target version.HOW to test your changes?
Use a Hydrogen project that has an available upgrade. To verify instruction overwrite, make sure the matching
.hydrogen/upgrade-*.mdfile already exists before running the command:The command should run without the upgrade confirmation or instruction overwrite confirmation prompts.
Post-merge steps
None.