Skip to content

docs: fix default dropzone class names in Droppable and SortAnimation module example #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reyo77 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

docs: fix default dropzone class names in Droppable and SortAnimation module example #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-droppable-class-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/draggable': patch
---

Fix default dropzone class names in Droppable documentation and corrected SortAnimation browser module example.
4 changes: 2 additions & 2 deletions src/Droppable/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ Check out [Draggable class identifiers](../Draggable#classes) for the base class

| Name | Description | Default |
| -------------------- | ------------------------------------------------------------------------ | ------------------------------- |
| `droppable:active` | Class added to the unoccupied dropzone elements when drag starts | `draggable-droppable--active` |
| `droppable:occupied` | Class added to the dropzone element when it contains a draggable element | `draggable-droppable--occupied` |
| `droppable:active` | Class added to the unoccupied dropzone elements when drag starts | `draggable-dropzone--active` |
| `droppable:occupied` | Class added to the dropzone element when it contains a draggable element | `draggable-dropzone--occupied` |

### Example

Expand Down
4 changes: 2 additions & 2 deletions src/Plugins/SortAnimation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ const sortable = new Sortable(document.querySelectorAll('ul'), {
```html
<script type="module">
import Sortable from 'https://cdn.jsdelivr.net/npm/@shopify/draggable/build/esm/Sortable/Sortable.mjs';
import Snappable from 'https://cdn.jsdelivr.net/npm/@shopify/draggable/build/esm/Plugins/Snappable.mjs';
import SortAnimation from 'https://cdn.jsdelivr.net/npm/@shopify/draggable/build/esm/Plugins/SortAnimation.mjs';

const sortable = new Sortable(document.querySelectorAll('ul'), {
draggable: 'li',
sortAnimation: {
duration: 200,
easingFunction: 'ease-in-out',
},
plugins: [Snappable],
plugins: [SortAnimation],
});
</script>
```
Expand Down
Loading