fix(swap-animation): guard against undefined elements when sorting in… - #678
Open
Reyo77 wants to merge 1 commit into
Open
fix(swap-animation): guard against undefined elements when sorting in…#678Reyo77 wants to merge 1 commit into
Reyo77 wants to merge 1 commit into
Conversation
…to empty containers
Author
|
I have signed the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements or fixes...
Fixes an unhandled
TypeError: Cannot read property 'style' of undefinedinSwapAnimationwhen dragging an item into an empty container (or whendragEvent.overisundefined).Also adds a comprehensive unit test suite in
src/Plugins/SwapAnimation/tests/SwapAnimation.test.tscovering vertical and horizontal animations, empty container sorting, transition cleanups, and option handling.This PR closes the following issues...
Closes #261
Closes #114
Does this PR require the Docs to be updated?
No.
Does this PR require new tests?
Yes, new unit tests added in
src/Plugins/SwapAnimation/tests/SwapAnimation.test.ts.This branch been tested on...
tsc -b)eslint ./src ./test --max-warnings 0)yarn build)