Skip to content

[Refactor] Simplify buildSessionChoices with early return and map #8447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Refactor] Simplify buildSessionChoices with early return and map #8447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions packages/cli-kit/src/public/node/session-prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,13 @@ interface SessionChoice {
* @returns Array of session choices.
*/
function buildSessionChoices(sessions: Sessions, fqdn: string): SessionChoice[] {
const choices: SessionChoice[] = []
const fqdnSessions = sessions[fqdn]
if (!fqdnSessions) return []

if (fqdnSessions) {
for (const [userId, session] of Object.entries(fqdnSessions)) {
choices.push({
label: session.identity.alias ?? userId,
value: userId,
})
}
}

return choices
return Object.entries(fqdnSessions).map(([userId, session]) => ({
label: session.identity.alias ?? userId,
value: userId,
}))
}

/**
Expand Down
Loading