Skip to content

Prevent GitHub credentials from being logged locally - #8438

Merged
gonzaloriestra merged 1 commit into
mainfrom
gonzaloriestra/redact-github-auth-logs
Aug 31, 2026
Merged

Prevent GitHub credentials from being logged locally#8438
gonzaloriestra merged 1 commit into
mainfrom
gonzaloriestra/redact-github-auth-logs

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

GitHub helper scripts printed authentication tokens and signed download URLs to command output. This could expose credentials in local terminal history or agent transcripts. CI should be safe because it uses secrets instead of dev commands.

WHAT is this pull request doing?

  • Captures dev github print-auth output without echoing it.
  • Logs credential sources without logging credential values.
  • Stops printing signed LFS download URLs.
  • Fails clearly when dev cannot provide a token.
  • Adds regression tests for environment and dev token paths.

How to test your changes?

pnpm graphql-codegen:get-graphql-schemas and check that it doesn't include any token

Checklist

  • I have considered possible cross-platform impacts.
  • I have considered possible documentation changes; none are required.
  • I have considered analytics changes; none are required.
  • This changes internal tooling only; no changeset is required.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 31, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review August 31, 2026 08:12
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner August 31, 2026 08:12
@gonzaloriestra gonzaloriestra changed the title Prevent GitHub credentials from being logged Prevent GitHub credentials from being logged locally Aug 31, 2026

@dmerand dmerand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Aug 31, 2026
Merged via the queue into main with commit 3dd2b4f Aug 31, 2026
31 checks passed
@gonzaloriestra
gonzaloriestra deleted the gonzaloriestra/redact-github-auth-logs branch August 31, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants