Skip to content

Fix webhook subscription UID to omit the literal "undefined" for absent filters #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacroldan wants to merge 1 commit into
base: deploy-split/02-normalize-experience-type
Choose a base branch
from
+2 −2
Open

Fix webhook subscription UID to omit the literal "undefined" for absent filters #8046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/cli/models/extensions/extension-instance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ describe('buildUIDFromStrategy', async () => {
// Given
const extensionInstance = await testSingleWebhookSubscriptionExtension()
// Then
expect(extensionInstance.uid).toBe('orders/delete::undefined::https://my-app.com/webhooks')
expect(extensionInstance.uid).toBe('orders/delete::::https://my-app.com/webhooks')
})

test('returns a custom string when strategy is dynamic and it is a webhook subscription extension with filters', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/cli/models/extensions/extension-instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
// Related issues: PR #559094 in old Core repo
if ('topic' in this.configuration && 'uri' in this.configuration) {
const subscription = this.configuration as unknown as SingleWebhookSubscriptionType
return `${subscription.topic}::${subscription.filter}::${subscription.uri}`.substring(0, MAX_UID_LENGTH)
return `${subscription.topic}::${subscription.filter ?? ''}::${subscription.uri}`.substring(0, MAX_UID_LENGTH)
} else {
return nonRandomUUID(JSON.stringify(this.configuration))
}
Expand Down
Loading