Skip to content

Remove store search support flag#8021

Merged
isaacroldan merged 1 commit into
mainfrom
remove-supports-store-search
Jul 9, 2026
Merged

Remove store search support flag#8021
isaacroldan merged 1 commit into
mainfrom
remove-supports-store-search

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Remove the supportsStoreSearch capability from DeveloperPlatformClient.
  • Always pass store-name search to the store selection prompt.
  • Clean up test client stubs and store-selection coverage.

Validation:

  • pnpm vitest run packages/app/src/cli/services/dev/select-store.test.ts
  • pnpm --filter app type-check
  • pnpm --filter app lint
  • pnpm knip

@isaacroldan isaacroldan marked this pull request as ready for review July 7, 2026 10:41
@isaacroldan isaacroldan requested a review from a team as a code owner July 7, 2026 10:41
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 7, 2026
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch from 27266d8 to d313a88 Compare July 7, 2026 13:12
@isaacroldan isaacroldan force-pushed the remove-supports-store-search branch from d14aabf to d2cd678 Compare July 7, 2026 13:12
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch from d313a88 to f98548c Compare July 7, 2026 13:31
@isaacroldan isaacroldan force-pushed the remove-supports-store-search branch from d2cd678 to 90d5dba Compare July 7, 2026 13:31
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch from f98548c to 93f86e3 Compare July 8, 2026 09:35
@isaacroldan isaacroldan force-pushed the remove-supports-store-search branch from 90d5dba to 041e7b7 Compare July 8, 2026 09:35
Assisted-By: devx/782ef931-ac0a-4cc4-bff1-a2511c379664
@isaacroldan isaacroldan force-pushed the remove-supports-store-search branch from 041e7b7 to cd3114e Compare July 8, 2026 09:58
@isaacroldan isaacroldan force-pushed the remove-legacy-dev-preview-concepts branch from 93f86e3 to 44cfd9a Compare July 8, 2026 09:58
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -6,7 +6,6 @@ export declare const environmentVariables: {
     doctor: string;
     enableCliRedirect: string;
     env: string;
-    firstPartyDev: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -63,13 +63,6 @@ export declare function alwaysLogAnalytics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_ALWAYS_LOG_METRICS is truthy.
  */
 export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
-/**
- * Returns true if the CLI User is 1P.
- *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if SHOPIFY_CLI_1P is truthy.
- */
-export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

Base automatically changed from remove-legacy-dev-preview-concepts to main July 9, 2026 11:12
@isaacroldan isaacroldan added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit 5a99ef3 Jul 9, 2026
28 of 29 checks passed
@isaacroldan isaacroldan deleted the remove-supports-store-search branch July 9, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants