Skip to content

[Security] Harden client ID generation in ExtensionServerClient #7933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Draft

[Security] Harden client ID generation in ExtensionServerClient #7933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce43151
[Security] Harden client ID generation in ExtensionServerClient
gonzaloriestra Jun 26, 2026
fc13eb4
[Security] Harden client ID generation in ExtensionServerClient
gonzaloriestra Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cli-kit/src/cli/api/graphql/admin/generated/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ export type OnlineStoreThemeFilesUserErrorsCode =
| 'LESS_THAN_OR_EQUAL_TO'
/** The record with the ID used as the input value couldn't be found. */
| 'NOT_FOUND'
/** Theme contextualization and condition types are not compatible with each other. */
| 'THEME_CONTEXTUALIZATION_NOT_COMPATIBLE_WITH_CONDITION_TYPES'
/** There are theme files with conflicts. */
| 'THEME_FILES_CONFLICT'
/** This action is not available on your current plan. Please upgrade to access theme editing features. */
Expand Down
5 changes: 4 additions & 1 deletion packages/ui-extensions-server-kit/src/ExtensionServerClient/ExtensionServerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ export class ExtensionServerClient implements ExtensionServer.Client {
private uiExtensionsByUuid: Record<string, ExtensionServer.UIExtension> = {}

constructor(options: DeepPartial<ExtensionServer.Options> = {}) {
this.id = (Math.random() + 1).toString(36).substring(7)
this.id =
typeof globalThis.crypto?.randomUUID === 'function'
? globalThis.crypto.randomUUID()
: (Math.random() + 1).toString(36).substring(7)
this.options = getValidatedOptions({
...options,
connection: {
Expand Down
Loading