[Tests] Refactor include-assets-step tests to use real filesystem#7932
[Tests] Refactor include-assets-step tests to use real filesystem#7932gonzaloriestra wants to merge 2 commits into
Conversation
Refactored `packages/app/src/cli/services/build/steps/include-assets-step.test.ts` to replace brittle filesystem mocks with real operations using `inTemporaryDirectory`.
Key changes:
- Removed `vi.mock('@shopify/cli-kit/node/fs')`.
- Wrapped all test cases in `inTemporaryDirectory`.
- Updated test setup to create real files and directories.
- Updated assertions to check the actual state of the filesystem.
- Corrected a test case that was asserting manifest overwrite behavior when the implementation actually performs a merge.
- Fixed type-check issues by properly casting the `environment` option and using correct `mkdir` signatures.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Refactored `packages/app/src/cli/services/build/steps/include-assets-step.test.ts` to replace brittle filesystem mocks with real operations using `inTemporaryDirectory`.
Key changes:
- Removed `vi.mock('@shopify/cli-kit/node/fs')`.
- Wrapped all test cases in `inTemporaryDirectory`.
- Updated test setup to create real files and directories.
- Updated assertions to check the actual state of the filesystem.
- Corrected a test case that was asserting manifest overwrite behavior when the implementation actually performs a merge.
- Fixed type-check issues by properly casting the `environment` option.
- Synchronized `packages/cli-kit/src/cli/api/graphql/admin/generated/types.d.ts` with the latest schema changes to resolve CI failure.
1 participant
Refactored the test suite for the
include-assets-stepbuild service to eliminate filesystem mocking in favor of real integration tests using temporary directories. This improves test reliability and aligns with repository standards. Verified with unit tests, linting, and type-checking.PR created automatically by Jules for task 12475560089181371150 started by @gonzaloriestra