Skip to content

[Performance] Memoize isWsl result #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −3
Draft

[Performance] Memoize isWsl result #7930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/cli-kit/src/public/node/system.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,3 +393,15 @@ describe('readStdinString', () => {
await expect(got).rejects.toThrow('Stdin input exceeded the maximum allowed size.')
})
})

describe('isWsl', () => {
test('memoizes the result', async () => {
// When
const result1 = system.isWsl()
const result2 = system.isWsl()

// Then
expect(result1).toBe(result2)
await expect(result1).resolves.toBeDefined()
})
})
13 changes: 10 additions & 3 deletions packages/cli-kit/src/public/node/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,14 +354,21 @@ export function isCI(): boolean {
return isTruthy(process.env.CI)
}

/**
* Memoized value for the WSL check.
*/
let memoizedIsWsl: Promise<boolean> | undefined

/**
* Check if the current environment is a WSL environment.
*
* @returns True if the current environment is a WSL environment.
*/
export async function isWsl(): Promise<boolean> {
const wsl = await import('is-wsl')
return wsl.default
export function isWsl(): Promise<boolean> {
return (memoizedIsWsl ??= (async () => {
const wsl = await import('is-wsl')
return wsl.default
})())
}

/**
Expand Down
Loading