[Tests] Refactor build/extension.test.ts to remove fs mocks#7924
[Tests] Refactor build/extension.test.ts to remove fs mocks#7924gonzaloriestra wants to merge 2 commits into
Conversation
Refactored `packages/app/src/cli/services/build/extension.test.ts` to use real filesystem operations within temporary directories instead of mocking `@shopify/cli-kit/node/fs`. This aligns with the project's testing guidelines and improves test reliability.
Changes:
- Removed `vi.mock('@shopify/cli-kit/node/fs')`.
- Wrapped tests in `inTemporaryDirectory`.
- Used real `mkdir`, `touchFile`, and `writeFile` for setup.
- Updated extension configurations to use paths within the temporary directory.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Refactored `packages/app/src/cli/services/build/extension.test.ts` to use real filesystem operations within temporary directories instead of mocking `@shopify/cli-kit/node/fs`. This aligns with the project's testing guidelines and improves test reliability. Fixed lint and type-check errors in the test file.
1 participant
Refactored
packages/app/src/cli/services/build/extension.test.tsto use real filesystem operations within temporary directories instead of mocking@shopify/cli-kit/node/fs. This aligns with the project's testing guidelines and improves test reliability.How to test your changes?
CI
PR created automatically by Jules for task 80830962309153810 started by @gonzaloriestra