[Performance] Memoize hasGit check#7923
Conversation
Memoize the result of the `hasGit` check to avoid redundant `git --version` shell executions. Concurrent calls now return the same promise, and subsequent calls return the cached result. Added unit tests to verify memoization and cache reset behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/context/local.d.ts@@ -132,6 +132,11 @@ export declare function cloudEnvironment(env?: NodeJS.ProcessEnv): {
* @returns A promise that resolves with the value.
*/
export declare function hasGit(): Promise<boolean>;
+/**
+ * Resets the memoized value for the hasGit check.
+ * This is only used for testing purposes.
+ */
+export declare function _resetHasGit(): void;
/**
* Gets info on the CI platform the CLI is running on, if applicable.
*
|
WHY are these changes introduced?
The
hasGitcheck runsgit --version, which is a shell command. Redundant executions of this check during a single CLI command lifecycle add unnecessary overhead.WHAT is this pull request doing?
Memoizes the result of
hasGitusing a module-level promise. This ensures thatgit --versionis executed at most once per process, and concurrent calls return the same promise.Expected performance impact: Reduces process execution overhead by avoiding redundant
git --versioncalls.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5396090806031353117 started by @gonzaloriestra