Repository navigation
feat(m3): add evidence collectors and ENV007–ENV012 rules - #3
Open
Shellghostt wants to merge 4 commits into
Open
Shellghostt wants to merge 4 commits into
Shellghostt wants to merge 4 commits into
Conversation
Shellghostt
marked this pull request as ready for review
November 15, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Implements ENV007–ENV012 with explicit Docker/API, declared dependency, package-manager, Git, virtualenv and proxy evidence. Pure snapshot evaluators and offline
explain/rules --jsonshare an immutable registry with all twelve generated rule pages. Adds bounded strict project/registry contracts, compatible optional snapshot evidence, redaction and collector uncertainty handling.Proxy networking is opt-in, bounded and sends no application bytes. Verification also fixes inherited subprocess output-limit bypass and preserves unknown Windows application-alias/interpreter evidence. All 54 original M2 fixtures retain their expected output; 118 reviewed cases bring the corpus to 172.
Closes #2
Why
ADR 0005 requires reliable observed prerequisites for each rule. Denied, failed or unknown evidence must not produce speculative findings. Shared registry metadata keeps CLI explanations, JSON and generated documentation consistent, and ordinary diagnosis remains offline.
How it was verified
M3 validation names acceptance tests, commands, live smoke checks and evidence limits.
make docs,make check-docsmake test, native Windowsmake racemake lint,make build,govulncheck ./...Dependency presence is bounded metadata evidence, not proof an SDK can link. Proxy TCP success does not establish authentication or forwarding. Native memory observations cover the recorded finite workloads; broader clean-host/M6 budgets remain later work. Temporary listeners and smoke files were cleaned up, and existing machine PATH/Docker data preserved.
Checklist
make lintpassesdocs/,README.mdroadmap, orapi/)docs/adr/