Repository navigation
feat(diagnose): complete M2 collectors and six rules - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Completes M2 collectors and rules: runtime, requested TCP-port, Git and local Docker inspection; diagnostic rules ENV001–ENV006;
--port; and offline--fixture-dirdiagnosis. Adds 54 Windows/Linux/macOS golden cases, built-CLI tests and rule documentation. Fixes collector deadlines, home-path redaction and degraded PATH inspection.Why
M1 collected environment facts but lacked the first actionable diagnostic rules. M2 identifies Python/Node conflicts, broken or shadowed PATH entries, occupied requested ports and unavailable Docker engines. ADR 0004 defines collection, evidence and offline diagnosis. Diagnosis remains read-only.
How it was verified
Executed commands and selected output:
All CI jobs passed, including Windows/Linux/macOS race tests. Validation also covered all 54 fixture cases through the built CLI, live TCP ownership checks and snapshot builds for six platform/architecture targets.
Checklist
make lintpassdocs/, README roadmap, snapshot schema and CHANGELOG)docs/adr/0004-m2-collectors-and-rules.md