Preserve blank MU* output lines in WorldSession - #18
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix empty lines not appearing in output
Preserve blank MU* output lines in WorldSession
Jul 31, 2026
Member
|
@copilot An example of what a game can send, for confirmation. |
Contributor
Author
... Confirmed and now covered by a regression test for that exact same-frame payload shape ( |
HarryCordewener
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consecutive newlines from the server were collapsing in the client output path, so intentional blank lines were not rendered. This change ensures empty completed lines are preserved as explicit empty
StyledLineentries.Output-path behavior change
WorldSession.OnOutputReceived(non-prompt path) to detect when parser/feed+flush emits no line for an output event.StyledLine.Emptyso blank server lines are retained in scrollback/output events.Regression coverage
EmptyOutputLine_IsAppendedAsBlankLineinWorldSessionTests.