Skip to content

Tidy the public API before 1.0 - #52

Merged
loevgaard merged 0 commit into
fix/29-cookie-domainfrom
fix/27-public-api
Sep 14, 2026
Merged

loevgaard merged 0 commit into
fix/29-cookie-domainfrom
fix/27-public-api

Conversation

@loevgaard

Copy link
Copy Markdown
Member

Fixes #27

Stacked on #51.

Problem

The Roave BC check will lock the public surface in at 1.0, and a few things were public but unused, undocumented, or both.

Change

Kept and documented

  • ConversionsApiEventRaised::$context is the way to hand your own listeners data that must never reach Meta, such as the order the event was raised for. It now says so in the docblock and in README.md, and it gained the getContext(string $key, mixed $default = null) accessor it was missing next to hasContext().
  • CommandInterface is genuinely useful for routing every command the bundle dispatches as a group. The docblock now shows the routing snippet, and the README mentions it.

Tightened

  • ConversionsApiEventRaised::$event and ::$context are readonly. The Event object stays mutable, which is what enrichment listeners need, but the properties can no longer be swapped.

Removed

  • The setono_meta_conversions_api.client_side.enabled and .server_side.enabled container parameters. No service read them once the subscribers became conditional, and whether a side is on is already visible from whether its services exist.

Tests

A test for getContext() including the default, and the extension test drops its assertions on the two removed parameters.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (fix/29-cookie-domain@e7e75f9). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             fix/29-cookie-domain      #52   +/-   ##
=======================================================
  Coverage                        ?   90.60%           
  Complexity                      ?      167           
=======================================================
  Files                           ?       34           
  Lines                           ?      543           
  Branches                        ?        0           
=======================================================
  Hits                            ?      492           
  Misses                          ?       51           
  Partials                        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@loevgaard
loevgaard force-pushed the fix/29-cookie-domain branch from 3f605cd to d692d8b Compare September 7, 2026 12:03
@loevgaard
loevgaard force-pushed the fix/29-cookie-domain branch from d692d8b to 17decfb Compare September 7, 2026 12:18
@loevgaard
loevgaard force-pushed the fix/29-cookie-domain branch from 17decfb to 8132598 Compare September 7, 2026 12:47
@loevgaard
loevgaard force-pushed the fix/29-cookie-domain branch from 8132598 to 1b315b0 Compare September 7, 2026 12:51
@loevgaard
loevgaard force-pushed the fix/29-cookie-domain branch from 1b315b0 to 2844117 Compare September 7, 2026 12:57
@loevgaard
loevgaard force-pushed the fix/27-public-api branch 2 times, most recently from 1a16cb3 to b740807 Compare September 14, 2026 07:51
@loevgaard
loevgaard merged commit b740807 into fix/29-cookie-domain Sep 14, 2026
@loevgaard
loevgaard deleted the fix/27-public-api branch September 14, 2026 07:52
@loevgaard
loevgaard restored the fix/27-public-api branch September 14, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant