Reduce httpd task priority to 5#66
Merged
Merged
Conversation
kahrendt
commented
Jun 8, 2026
Contributor
- The lower priority doesn't seem to cause a measurable increase in time message round trip times
- Could be beneficial for ESP32 (plain variant) with ethernet. It's a lower priority than the ethernet task so httpd can't potentially starve it
- The lower priority doesn't seem to cause a measurable increase in time message round trip times - Could be beneficial for ESP32 with ethernet; it's a lower priority than the ethernet task so httpd can't starve it
Contributor
There was a problem hiding this comment.
Pull request overview
This PR lowers the default FreeRTOS priority used for the ESP-IDF HTTP server task to reduce the chance that the HTTP server can starve higher-importance tasks (notably ethernet) on ESP32 targets, while keeping the sync/decode task priority one level above the HTTP server as documented and implemented.
Changes:
- Reduced
SendspinClientConfig::DEFAULT_HTTPD_PRIORITYfrom17to5. - Kept the sync/decode task default priority relationship intact (
DEFAULT_SYNC_TASK_PRIORITY = DEFAULT_HTTPD_PRIORITY + 1) and updated the integration guide defaults accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/sendspin/config.h | Lowers the default HTTP server task priority; sync/decode default priority remains derived as httpd + 1. |
| docs/integration-guide.md | Updates documented default httpd_priority to 5 and sync/decode default priority to 6 to match the code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.