Skip to content

Reduce httpd task priority to 5#66

Merged
kahrendt merged 1 commit into
mainfrom
modify-httpd-default-priority
Jun 8, 2026
Merged

Reduce httpd task priority to 5#66
kahrendt merged 1 commit into
mainfrom
modify-httpd-default-priority

Conversation

@kahrendt

@kahrendt kahrendt commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  • The lower priority doesn't seem to cause a measurable increase in time message round trip times
  • Could be beneficial for ESP32 (plain variant) with ethernet. It's a lower priority than the ethernet task so httpd can't potentially starve it

- The lower priority doesn't seem to cause a measurable increase in time message round trip times
- Could be beneficial for ESP32 with ethernet; it's a lower priority than the ethernet task so httpd can't starve it

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR lowers the default FreeRTOS priority used for the ESP-IDF HTTP server task to reduce the chance that the HTTP server can starve higher-importance tasks (notably ethernet) on ESP32 targets, while keeping the sync/decode task priority one level above the HTTP server as documented and implemented.

Changes:

  • Reduced SendspinClientConfig::DEFAULT_HTTPD_PRIORITY from 17 to 5.
  • Kept the sync/decode task default priority relationship intact (DEFAULT_SYNC_TASK_PRIORITY = DEFAULT_HTTPD_PRIORITY + 1) and updated the integration guide defaults accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
include/sendspin/config.h Lowers the default HTTP server task priority; sync/decode default priority remains derived as httpd + 1.
docs/integration-guide.md Updates documented default httpd_priority to 5 and sync/decode default priority to 6 to match the code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kahrendt kahrendt enabled auto-merge (squash) June 8, 2026 13:13
@kahrendt kahrendt merged commit e9c8e9d into main Jun 8, 2026
6 checks passed
@kahrendt kahrendt deleted the modify-httpd-default-priority branch June 8, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants