Skip to content

feat(models): label GLM-5.2 data as GLM-5.2/GLM-5.3 / 将 GLM-5.2 数据标注为 GLM-5.2/GLM-5.3 - #739

Open
Oseltamivir wants to merge 1 commit into
masterfrom
agent/add-glm-5-3-selection-label
Open

feat(models): label GLM-5.2 data as GLM-5.2/GLM-5.3 / 将 GLM-5.2 数据标注为 GLM-5.2/GLM-5.3#739
Oseltamivir wants to merge 1 commit into
masterfrom
agent/add-glm-5-3-selection-label

Conversation

@Oseltamivir

@Oseltamivir Oseltamivir commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Display-only label and test string updates; benchmark routing and data keys (GLM-5.2, glm5.2 prefix) are unchanged.

Overview
Updates the display label for Model.GLM_5_2 from GLM5.2 to GLM5.2/GLM5.3 in MODEL_CONFIG, with a short comment that GLM-5.2 and GLM-5.3 share the same architecture and inference profile so both releases are shown against the existing GLM-5.2 data bucket (no new model key or prefix).

Tests align with the new label in getModelLabel and the overview Cypress MODEL_LABELS fixture.

Reviewed by Cursor Bugbot for commit aa0c60c. Bugbot is set up for automated code reviews on this repo. Configure here.

Show GLM5.2/GLM5.3 in shared model-selection labels while retaining the existing GLM-5.2 model key and benchmark bucket.

中文:共享模型选择标签改为显示 GLM5.2/GLM5.3,同时保留现有 GLM-5.2 模型键与基准测试数据分组。
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview Aug 14, 2026 3:34pm

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit aa0c60c. Configure here.

[Model.GLM_5_2]: { label: 'GLM5.2', prefix: 'glm5.2', category: 'default' },
// GLM-5.2 and GLM-5.3 share the same architecture and inference profile, so
// the selector presents both releases over the existing GLM-5.2 data bucket.
[Model.GLM_5_2]: { label: 'GLM5.2/GLM5.3', prefix: 'glm5.2', category: 'default' },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete GLM dual-version labeling

Low Severity

The PR renames the selector label to GLM5.2/GLM5.3, but /compare and /compare-per-dollar still read label from compare-slug.ts, which remains GLM 5.2. That registry does not derive from MODEL_CONFIG, so compare headers, OG images, and page copy keep the old single-version name while overview and chart selectors show both releases.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit aa0c60c. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant