Fix for multicolumns user manual menu in devices with 480px or less#21
Merged
Merged
Conversation
It does not work without important as reality has it.
Member
|
@ivanhercaz Thanks a lot for this easy as well as smart solution. On a narrow screen the menu is to much aligned to the left so it gets hidden. Thus we need another tweak. The only thing that really fatigues me is that it just puts the content of the third column to the second one. It will be nice if the content of the second column gets added to the first before, but I am afraid we would need JavaScript for this. Never mind however, I still need to clean out links to make this less apparent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to #11 and #17, I made this fix to change the three columns of the user manual menu to two columns. It should work without
!importantand any additional media query, but as we seen in #17, maybe could be necessary to make another trick like use!importantor made another media query, although this isn't confirmed that work per #20.Test it in live, @kghbln, and tell me if it works only with this code or if it's necessary to use one of the both tricks I mentioned.
Regards,
Iván