Describe testing beforeunload in alerts.en.md#2266
Conversation
Related info for ChromeDriver: https://issues.chromium.org/issues/351858989#comment30
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
Cross-reference the beforeunload/BiDi/ChromeDriver caveat from the alerts docs to the unhandledPromptBehavior section in options docs, where the capability is already documented per language, instead of duplicating binding-specific syntax inline. Added in all four languages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review by Qodo
Context used✅ Compliance rules (platform):
10 rules 1.
|
Qodo flagged the new ja/pt-br/zh-cn notes as single unwrapped lines (up to 209 chars), violating the line-length rule in the style guide. Wrap using semantic linefeeds; rendered output is unchanged since Markdown collapses the soft line breaks to a single space. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Code review by qodo was updated up to the latest commit 4e6191a |
* Describe testing beforeunload in alerts.en.md Related info for ChromeDriver: https://issues.chromium.org/issues/351858989#comment30 * Document beforeunload prompt behavior with unhandledPromptBehavior Cross-reference the beforeunload/BiDi/ChromeDriver caveat from the alerts docs to the unhandledPromptBehavior section in options docs, where the capability is already documented per language, instead of duplicating binding-specific syntax inline. Added in all four languages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Wrap translated beforeunload notes to ~100 char lines Qodo flagged the new ja/pt-br/zh-cn notes as single unwrapped lines (up to 209 chars), violating the line-length rule in the style guide. Wrap using semantic linefeeds; rendered output is unchanged since Markdown collapses the soft line breaks to a single space. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Diego Molina <diemol@users.noreply.github.com> [deploy site] 4e8e129
User description
Description
Describe testing beforeunload in alerts.en.md
Motivation and Context
I'm working on upgrading the driver used by a test suite and it took me a long time to discover this information.
Related info: https://issues.chromium.org/issues/351858989#comment30
Types of changes
Checklist
I'm willing to sign the CLA but I don't know how.Signed.PR Type
Documentation
Description
Added a new section on
beforeunloadprompt behavior inalerts.en.md.Explained default behavior changes for drivers released in 2024 and later.
Provided specific notes on ChromeDriver versions and configuration requirements.
Changes walkthrough 📝
alerts.en.md
Added documentation for `beforeunload` prompt behaviorwebsite_and_docs/content/documentation/webdriver/interactions/alerts.en.md
beforeunloadprompt behavior.configuration.